This repository was archived by the owner on Feb 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
[Merged by Bors] - Logging #187
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for OpenSearch Dashboards provided by the service
sbernauer
reviewed
Dec 12, 2022
Member
|
Demo worked for me as well |
Member
sbernauer
approved these changes
Dec 13, 2022
Member
sbernauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait for Felix
fhennig
reviewed
Dec 13, 2022
fhennig
approved these changes
Dec 19, 2022
Contributor
fhennig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy now 😃 LGTM!
sbernauer
approved these changes
Dec 19, 2022
Member
sbernauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy as well
Member
Author
|
bors merge |
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
stackablectl services list.TODOs before merging:
demos/demos-v1.yaml: Replacehttps://github.com/stackabletech/stackablectl/logging/demos/logging/zookeeper.yamlwithhttps://github.com/stackabletech/stackablectl/main/demos/logging/zookeeper.yaml.stacks/stacks-v1.yaml: Replacehttps://github.com/stackabletech/stackablectl/logging/stacks/logging/vector-aggregator-discovery.yamlwithhttps://github.com/stackabletech/stackablectl/main/stacks/logging/vector-aggregator-discovery.yaml.demos/logging/zookeeper.yaml: Removerepo: docker.stackable.tech/sandbox/loggingwhen Logging docker-images#268 is merged and the images are built and deployed.releases/releases.yaml: Remove the file when [Merged by Bors] - Logging zookeeper-operator#588 is merged.stacks/stacks-v1.yaml: ReplacestackableRelease: 22.11-loggingwithstackableRelease: 22.11when [Merged by Bors] - Logging zookeeper-operator#588 is merged.Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information